Allow configuring CODEQL_THREADS with an env var

[austinpray-mixpanel]

closes #2890

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Confirm the readme has been updated if necessary.
• Confirm the changelog has been updated if necessary.

[Copilot]

Pull Request Overview

This PR enables configuring the number of CodeQL threads via an environment variable.

• Allows users to override the thread count using CODEQL_THREADS in the environment.
• Falls back to computing the thread value based on the "threads" input if the env var is not set.

[aeisenberg]

Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.

Can you try this alternate approach?

In the init/actions.yml file add default: "${{ env.CODEQL_THREADS }}" to the threads input. This should be sufficient.

[austinpray-mixpanel]

Thanks for your PR. I don't think this is harmful or could break anything, but it seems a bit redundant.

Can you try this alternate approach?

In the init/actions.yml file add default: "${{ env.CODEQL_THREADS }}" to the threads input. This should be sufficient.

Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated

[aeisenberg]

Yep I can give this a shot. My initial change was just trying to match up the way the ram variable was treated

Great. Let me know if this works for you. Now that I'm engaged, I'll be able to respond more quickly to this PR.

[austinpray-mixpanel]

@aeisenberg lmk what you think 👍

[aeisenberg]

This looks right to me.

[austinpray-mixpanel]

@aeisenberg ah I don't think you can use env variable expressions in inputs

Error: /Users/runner/work/codeql-action/codeql-action/./../action/init/action.yml (Line: 118, Col: 14): Unrecognized named-value: 'env'. Located at position 1 within expression: env.CODEQL_THREADS

[aeisenberg]

Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere.

[aibaars]

Oh...that's really unfortunate. Apologies for the confusion. I'm asking internally what's going on since this is a pattern that's being used elsewhere.

Most of those examples commented out the default field with a # though. I'm not sure why the env context is not allowed, perhaps it is not available until a workflow starts to "run".

[austinpray-mixpanel]

In any case it probably makes sense to have the threads and ram behavior configuration be exactly the same so there aren't any surprises

[henrymercer]

Thanks for the contribution @austinpray-mixpanel! Could you follow the instructions in https://github.com/github/codeql-action/blob/main/CONTRIBUTING.md#common-tasks to rebuild the project?

[austinpray-mixpanel]

@henrymercer done 👍

[austinpray-mixpanel]

Thank you all!