Go: Support GOPROXY via the Dependabot proxy#2834
Merged
Conversation
5e994c3 to
6ad5d99
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the mapping for the Go language so that Dependabot now correctly uses the "goproxy_server" registry type instead of an empty string.
- Update in src/start-proxy.ts to add the correct registry type for Go
- Update in lib/start-proxy.js to reflect the same change for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/start-proxy.ts | Added "go: 'goproxy_server'" and removed the duplicated empty entry |
| lib/start-proxy.js | Updated the Go registry type to "goproxy_server" and removed the empty entry |
aeisenberg
approved these changes
Apr 25, 2025
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
LGTM.
Do we have an integration test for this?
Member
Author
|
@aeisenberg We have a test repository for this (I'll send you a link). I am also hoping to look at building a better test framework for the private registry support in the near future, similar to what we currently have for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now support the
goproxy_serverregistry type for Go. This PR updates theLANGUAGE_TO_REGISTRY_TYPErecord so that we don't abort getting the credentials for corresponding configurations.Merge / deployment checklist