Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR reverts the previous change that preferred the use of GNU tar ("gtar") over the system tar, restoring the original behavior that uses BSD tar on macOS.
- Reverts the "prefer gtar" change as per codeql-action#2767.
- Removes the conditional logic that preferred "gtar", and the extra parameter from getTarVersion in both TypeScript and JavaScript implementations.
- Updates logging and error messages to consistently reference "tar" rather than a variable command name.
Changes
| File | Description |
|---|---|
| CHANGELOG.md | Updates the changelog to indicate that there are no user-facing changes. |
| src/tar.ts | Removes usage of gtar: simplifies getTarVersion and updates command logging to always use "tar". |
| lib/tar.js | Mirrors the TypeScript changes; removes pickTarCommand and updates error messages and logging accordingly. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
cklin
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2767 now that we have #2768.
Using BSD tar on macOS minimises changes to the prod environment. It also means we only need to support (macOS, BSD tar) rather than (macOS, GNU tar) and (macOS, fallback to BSD tar). One drawback of reverting #2767 is that preferring GNU tar does mean we're using the same program to archive and extract the CodeQL Bundle.