Merge main into releases/v3#2739
Closed
github-actions[bot] wants to merge 10 commits intoreleases/v3from
Closed
Conversation
Mergeback v3.28.6 refs/heads/releases/v3 into main
start-proxy: Remove unusued proxy_password input
start-proxy: Skip proxy setup if no credentials are available
Contributor
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
start-proxy/action.yml:10
- The removal of the proxy_password input is a user-facing change that is not documented. If you intend to remove it, please update the changelog accordingly; otherwise, restore the input.
proxy_password:
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
Comment on lines
+7
to
+8
| No user facing changes. | ||
|
|
There was a problem hiding this comment.
Removing the proxy_password input is a user-facing change, so this line is misleading. Please update the changelog to reflect the removal of the proxy_password input or revert its removal if it was unintentional.
Suggested change
| No user facing changes. | |
| - Removed the `proxy_password` input. [#XXXX](https://github.com/github/codeql-action/pull/XXXX) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging 54b1c84 into
releases/v3.Conductor for this PR is @marcogario.
Contains the following pull requests:
Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.