remove normalize.css replace with minimal built-in reset #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the normalize.css v3.0.0 dependency and replaces it with a minimal, custom CSS reset. This simplifies the project's dependencies while maintaining essential cross-browser consistency for the most commonly needed CSS resets.
Key Changes:
- Removed the normalize-css bower dependency from bower.json
- Deleted all normalize.css vendor files (CSS, documentation, and configuration)
- Added a minimal custom CSS reset with essential properties: universal box-sizing, text-size-adjust, body margin reset, form element font inheritance, and image border reset
Reviewed changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| bower.json | Removed normalize-css dependency from bower dependencies |
| assets/vendor/normalize-css/normalize.css | Deleted entire normalize.css v3.0.0 file (423 lines) |
| assets/vendor/normalize-css/bower.json | Deleted normalize-css bower configuration |
| assets/vendor/normalize-css/README.md | Deleted normalize.css documentation |
| assets/vendor/normalize-css/LICENSE.md | Deleted normalize.css license file |
| assets/vendor/normalize-css/.bower.json | Deleted bower metadata file |
| assets/css/application.scss | Replaced normalize.css import with minimal custom CSS reset (20 lines) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1137