Skip to content

chore: update sap-ux-fiori-tools to 1.16.6 - #5880

Closed
IainSAP wants to merge 1 commit into
github:mainfrom
IainSAP:update-sap-ux-fiori-tools-1.16.6
Closed

IainSAP wants to merge 1 commit into
github:mainfrom
IainSAP:update-sap-ux-fiori-tools-1.16.6

Conversation

@IainSAP

@IainSAP IainSAP commented Oct 28, 2026

Copy link
Copy Markdown

Pull Request Checklist

  • I have read the contribution guidelines
  • I have reviewed the guidance for paid services (if applicable)
  • I have added files to the correct directories
  • I have followed naming conventions
  • I have tested my changes with GitHub Copilot
  • I have run npm start to verify README updates

Description

Updates the sap-ux-fiori-tools plugin version from 1.16.0 to 1.16.6 and updates the source SHA to match the latest release commit in SAP/open-ux-tools.

Type of Contribution

  • Update to existing item

Additional Notes

  • New version: 1.16.6
  • New SHA: 4fb662cb3c3e5600c8f4e80dc340c909fbcdedf0 (commit: chore: apply latest changesets, 2026-10-28)

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@IainSAP
IainSAP requested a review from a team as a code owner October 28, 2026 17:03
@github-actions github-actions Bot added external-plugin Public external plugin submission plugin PR touches plugins merge-risk:high labels Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Submission status: ⏳ Awaiting automation

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier
  • plugins/external.json is a high-risk path (automation, scripts, MCP config, hooks, or review policy)

Automated checks

Check Status Details
Line endings ⏳ Pending Running · logs
Spelling ⏳ Pending Running · logs
Generated README consistency ⏳ Pending Running · logs
Plugin and extension validation ⏳ Pending Running · logs
Plugin structure ⏳ Pending Running · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ⏳ Pending (advisory, non-blocking) Running · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs
Canvas/plugin smoke test ⏳ Pending Running · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s); an approval from a maintainer with admin or maintain permission
  • The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 6b5c049 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 1 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions github-actions Bot added the requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🛑 External plugin PR checks failed (submitter fixes required)

  • Changed entries detected: 1
  • Workflow state label: requires-submitter-fixes
  • Full logs: Download quality gate artifact
  • Status legend: ✅ pass · ⚠️ warning · 🛑 fail

Per-plugin quality summary

Plugin spec compliance vally lint install smoke test version match ref/sha consistency canvas structure overall source tree
sap-ux-fiori-tools 🛑 fail ✅ pass ✅ pass ✅ pass ⚪ not_run ⚪ not_run 🛑 fail 4fb662cb3c3e5600c8f4e80dc340c909fbcdedf0

Gate output details

sap-ux-fiori-tools - spec compliance (🛑 fail)

Agent Plugins v1.0.0 manifest errors:
- manifest location is ".github/plugin/plugin.json"; expected "plugin.json" at plugin root
sap-ux-fiori-tools - vally lint (✅ pass)

✅ sap-fiori-add-visual-filter (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-analytical-chart (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-app-development (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-create-cli (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-eslint-plugin (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-opa5-test-development (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.
✅ sap-fiori-tree-table (2/2 checks passed)

...output truncated...
sap-ux-fiori-tools - install smoke test (✅ pass)

Install smoke test succeeded. Verified /tmp/external-plugin-quality-KHMniY/copilot-home/.copilot/installed-plugins/external-plugin-intake/sap-ux-fiori-tools/.github/plugin/plugin.json.
sap-ux-fiori-tools - version match (pass)

- 4fb662cb3c3e5600c8f4e80dc340c909fbcdedf0: matched version "1.16.6" at "plugins-coding-agents/fiori/.github/plugin/plugin.json".
sap-ux-fiori-tools - ref/sha consistency (not_run)

Ref/SHA consistency gate skipped because one of source.ref or source.sha was not provided.
sap-ux-fiori-tools - canvas structure (not_run)

Canvas structure gate skipped because plugin is not tagged with "canvas".
- sap-ux-fiori-tools: spec=fail, vally-lint=pass, install-smoke=pass, version-match=pass, ref-sha-consistency=not_run, canvas-structure=not_run, overall=fail

@IainSAP

IainSAP commented Oct 28, 2026

Copy link
Copy Markdown
Author

Closing to resubmit with correct formatting — accidental full-file reformat.

@IainSAP IainSAP closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-plugin Public external plugin submission merge-risk:high plugin PR touches plugins requires-submitter-fixes Submission has quality-gate findings that submitter must fix before maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant