Repository navigation
Add optional error handoff to repository-local canvas boards - #5706
Merged
Merged
Conversation
Offer optional, redacted Send to agent requests with confirmed child-session outcomes across the four local boards. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🚦 Submission status: 👀 Ready for reviewRisk tier: Why this tier
Automated checks
Review
Commands
Updated for |
Contributor
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
github-actions
Bot
added
needs-review:MEDIUM
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Confirmed security, handoff correctness, and accessibility defects remain unresolved.
8 open issues
What changed in this PR
Adds optional Send to agent handoff to four repository-local canvas boards, leaving public canvases unchanged.
Changes:
- Introduces a shared error tray with diagnostic redaction and parent-mediated child-session confirmation.
- Integrates generated helpers and error markers into the existing boards.
- Adds synchronization tooling, regression coverage, and maintainer documentation.
| File | Description |
|---|---|
eng/sync-canvas-error-handoff.mjs |
Generates and checks local helper copies. |
eng/canvas-error-handoff/runtime.mjs |
Implements error capture, handoff requests, and confirmation. |
eng/canvas-error-handoff.test.mjs |
Covers redaction, requests, UI behavior, and synchronization. |
docs/maintainers/canvas-evidence-and-metrics.md |
Documents privacy, behavior, and maintenance. |
.github/extensions/resource-staleness-board/public/app.js |
Marks preview and resource errors. |
.github/extensions/resource-staleness-board/extension.mjs |
Connects SDK and server wrappers. |
.github/extensions/resource-staleness-board/error-handoff.mjs |
Adds the generated staleness-board helper. |
.github/extensions/open-pr-board/README.md |
Documents the optional handoff action. |
.github/extensions/open-pr-board/public/app.js |
Marks detail-loading errors. |
.github/extensions/open-pr-board/lib/server.mjs |
Uses the handoff server with an injectable factory. |
.github/extensions/open-pr-board/extension.mjs |
Configures SDK wrappers. |
.github/extensions/open-pr-board/error-handoff.mjs |
Adds the generated Open PR helper. |
.github/extensions/external-plugin-review-board/README.md |
Documents the optional handoff action. |
.github/extensions/external-plugin-review-board/public/app.js |
Marks issue-detail errors. |
.github/extensions/external-plugin-review-board/lib/server.mjs |
Uses the handoff server wrapper. |
.github/extensions/external-plugin-review-board/extension.mjs |
Configures SDK wrappers. |
.github/extensions/external-plugin-review-board/error-handoff.mjs |
Adds the generated plugin-review helper. |
.github/extensions/duplicate-review-board/public/app.js |
Marks background-review errors. |
.github/extensions/duplicate-review-board/extension.mjs |
Connects SDK and server wrappers. |
.github/extensions/duplicate-review-board/error-handoff.mjs |
Adds the generated duplicate-review helper. |
Review effort: Max
Keep capabilities in canvas URL fragments rather than HTTP bootstrap responses, and reject unauthorized dispatch and status requests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Redact complete cookie fields with bounded processing, deduplicate diagnostics across operations, exclude expected notices and rendered content, and keep handoff controls inside the active modal without covering recovery actions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
awaiting-automation
ready-for-review
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved diagnostic privacy and handoff reliability defects prevent safe use of the new action.
9 open issues
8 resolved since last review
Review effort: Max
Sanitize URLs before token replacement, propagate child safety boundaries, retain receipts, deduplicate board error prefixes, and exclude expected guidance toasts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
awaiting-automation
ready-for-review
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Security-sensitive server wrapping and child-session creation require fixes and end-to-end desktop validation before human approval.
5 open issues
gh.postCommentis pending, the subsequent… · Newtoast(error.message, { error: true })at line 828.… · Newcancel_workrequest reachesBoardStore.check, which still throws a plain error when its… · New
3 resolved since last review
Review effort: Max
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The child-session creation and confirmation flow crosses browser and agent boundaries but lacks end-to-end validation in the desktop runtime.
1 open issue
5 resolved since last review
cancel_workrequest reachesBoardStore.check, which still throws a plain error when its…toast(error.message, { error: true })at line 828.…gh.postCommentis pending, the subsequent…
Review effort: Max
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve periodic refresh provenance and error handoff classification. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved credential redaction, receipt handling, inline-script insertion, notice classification, focus restoration, action-error reporting, and CI synchronization issues block approval.
9 open issues
Authorization: token SYNTHETIC_CREDENTIALbecomes `Authorization: [redacted]…
2 resolved since last review
Review effort: Max
Preserve literal inline configuration and suppress expected approval preflights. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The security-sensitive handoff has unresolved defects, and real desktop child-session creation and receipt delivery remain unverified.
3 open issues
/startwaits forsession.sendto settle even whenrecord_error_handoffhas already stored a… · New
9 resolved since last review
Authorization: token SYNTHETIC_CREDENTIALbecomes `Authorization: [redacted]…
Review effort: Max
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical credential leakage and the new cross-board dependency remain unresolved, alongside diagnostic-loss and notice-classification defects.
8 open issues
open-pr-board. Before this PR,… · Newextension.mjs: the board's store now cannot load unless the… · New
3 resolved since last review
Review effort: Max
Comment on lines
+50
to
+53
| const fragment = text.slice(start, end + 1); | ||
| let sanitized = fragment; | ||
| try { sanitized = JSON.stringify(sanitizeJson(JSON.parse(fragment), nesting + 1)); } | ||
| catch { sanitized = "[redacted invalid JSON diagnostic]"; } |
Comment on lines
+50
to
+53
| const fragment = text.slice(start, end + 1); | ||
| let sanitized = fragment; | ||
| try { sanitized = JSON.stringify(sanitizeJson(JSON.parse(fragment), nesting + 1)); } | ||
| catch { sanitized = "[redacted invalid JSON diagnostic]"; } |
| import * as gh from "./lib/github.mjs"; | ||
| import { buildReviewPrompt, buildRereviewPrompt, REVIEW_FIELDS_SCHEMA } from "./lib/review-prompt.mjs"; | ||
| import { startBoardServer, expectedError } from "./lib/server.mjs"; | ||
| import { expectedNotice } from "../open-pr-board/lib/errors.mjs"; |
| import { mkdir, readFile, rename, writeFile } from "node:fs/promises"; | ||
| import { randomBytes } from "node:crypto"; | ||
| import path from "node:path"; | ||
| import { expectedNotice } from "../../open-pr-board/lib/errors.mjs"; |
Comment on lines
+50
to
+53
| const fragment = text.slice(start, end + 1); | ||
| let sanitized = fragment; | ||
| try { sanitized = JSON.stringify(sanitizeJson(JSON.parse(fragment), nesting + 1)); } | ||
| catch { sanitized = "[redacted invalid JSON diagnostic]"; } |
Comment on lines
+50
to
+53
| const fragment = text.slice(start, end + 1); | ||
| let sanitized = fragment; | ||
| try { sanitized = JSON.stringify(sanitizeJson(JSON.parse(fragment), nesting + 1)); } | ||
| catch { sanitized = "[redacted invalid JSON diagnostic]"; } |
Comment on lines
+49
to
+52
| const fragment = text.slice(start, end + 1); | ||
| let sanitized = fragment; | ||
| try { sanitized = JSON.stringify(sanitizeJson(JSON.parse(fragment), nesting + 1)); } | ||
| catch { sanitized = "[redacted invalid JSON diagnostic]"; } |
Comment on lines
+81
to
+83
| try { diagnostic = JSON.stringify(sanitizeJson(JSON.parse(raw))); } | ||
| catch { diagnostic = sanitizeEmbeddedJson(raw); } | ||
| return sanitizeText(diagnostic); |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
Handled canvas errors should be actionable without manually copying diagnostic details into another conversation. Adds an optional Send to agent action to the Open PR, External Plugin Review, Duplicate Review, and Resource Staleness boards under
.github/extensions/only. Public canvases underextensions/are unchanged.The additive error tray preserves existing messages, retry controls, and recovery behavior. Clicking dispatches a bounded, redacted diagnostic request, deduplicates repeated clicks, and displays success only after an actual child-session ID is confirmed. Dispatch and creation failures remain visible. A canonical runtime and generated local copies keep the four boards consistent; regression coverage and maintainer documentation describe the contract.
Type of Contribution
Additional Notes
The extension runtime does not expose direct child-session creation. Handoff therefore uses the supported parent-agent messaging path: the parent calls
create_sessionand reports the actual child ID or failure throughrecord_error_handoff. Message admission alone is never reported as creation. Real desktop child creation has not been exercised; browser checks used a mocked parent for confirmed success and failure. The Copilot integration checklist item remains unchecked for that reason. No new paid service integration is introduced, and this updates existing canvases rather than adding one.Validation:
node --experimental-vm-modules --test --test-reporter=spec eng\canvas-error-handoff.test.mjs eng\*board*.test.mjs eng\resource-staleness-*.test.mjs- passed, 278 tests after narrowing the scope.node eng\sync-canvas-error-handoff.mjs --check- passed, exactly four canvases.npm start- passed; generated README and marketplace remained unchanged.npm run plugin:validate- passed, 108 local plugins and 82 external entries.npm run website:data- passed.bash eng/fix-line-endings.sh- passed.git diff --cached --check- passed before committing.node --experimental-vm-modules eng\canvas-smoke-test.mjs --all --install never- failed on an existing Draw scanner false positive: unchanged private#requireis classified as a nonliteral require. That public canvas is outside this PR's scope.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.