Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document cooperative deadlines and allow screenshot-compatible finding callbacks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove reflow-specific caller handling and document fail-closed behavior for built-in, local, and NPM plugins. Keep core-engine error handling unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep existing log-and-continue caller handling; move configurable plugin failure policy to a separate PR per user direction. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLUGINS.md.Relates to #303
Scope split
Per user direction, configurable caller failure policy is in independent draft PR #306. Both drafts target
main; neither is stacked. This PR has no production changes tofindForUrlor the core scanner: existing logging and partial-result behavior is preserved. A caller integration regression verifies that behavior when reflow reports an error.Issue #303 was updated to align acceptance criteria with the selected policy. The companion PR adds
plugin_failure_policy, defaulting tolog-and-continue; selectingabortstops incomplete plugin work before findings publication. Neither default logging nor this plugin-local patch guarantees complete coverage. Both PRs use non-closing issue references so #303 is not closed by only one half of the split.Verification
npx --no-install vitest run .github/actions/find/tests/reflowScan.test.ts .github/actions/find/tests/findForUrl.test.ts .github/actions/find/tests/index.test.ts— 41 tests passed after the scope split.npm run build --prefix .github/actions/findpassed after the split.git diff --checkpassed.Dependency restoration was recovered via the configured registry proxy and offline installation of exact locked tarballs. No dependency manifests or lockfiles changed. The draft Test CI job is skipped; these results are local verification.
Limitations
Budgets are cooperative plugin-wait limits: up to 50 seconds with a finding callback, or 15 seconds without one, provided timers can run. They do not cancel in-flight Playwright operations or guarantee recovery from a blocked controller/event loop. Context/browser teardown is outside these budgets and can still hang; hard runtime recovery remains separate. Callbacks exceeding 35 seconds report an error rather than waiting indefinitely.
🤖 Assisted by Copilot