fix: cache GitHub App ID to reduce SSM calls #4994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Cache the GitHub App ID at module level to avoid repeated SSM parameter fetches on every rate limit metric update. The value is now fetched once per Lambda execution context and reused across invocations.
Brend-Smits
force-pushed
the
perf/cache-github-app-id
branch
from
7483a9d to
60eccce
Compare
guicaulada
reviewed
Jan 12, 2026
Contributor
There was a problem hiding this comment.
The implementation is solid and ready to merge from my perspective.
We should consider how this relates to the broader caching work in PR #4899, these may want to be coordinated.
This change is very low-risk and provides a clear performance benefit for high-volume environments. Work from #4899 can probably wait and be added later integrating this cache into the broader caching work.
There probably isn't any issues, but I will run some tests on our environment and come back to approve.
guicaulada
approved these changes
Jan 12, 2026
npalm
pushed a commit
that referenced
this pull request
Jan 13, 2026
🤖 I have created a release *beep* *boop* --- ## [7.3.0](v7.2.0...v7.3.0) (2026-01-13) ### Features * add bypass-removal tag to prevent runner scale-down ([#4995](#4995)) ([c0a9766](c0a9766)) ### Bug Fixes * cache GitHub App ID to reduce SSM calls ([#4994](#4994)) ([0fb6f4a](0fb6f4a)) * change runner_placement host_resource_group_arn type to be a string instead of a number ([#4979](#4979)) ([5405a04](5405a04)) * **lambda:** bump the aws group in /lambdas with 7 updates ([#4985](#4985)) ([5eacb0f](5eacb0f)) * **runners:** correct regex pattern for extracting AMI ID from SSM parameter ARN ([#4981](#4981)) ([174293c](174293c)), closes [#4959](#4959) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com> Co-authored-by: github-aws-runners-pr|bot <github-aws-runners-pr[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the GitHub App ID at module level to avoid repeated SSM parameter fetches on every rate limit metric update. The value is now fetched once per Lambda execution context and reused across invocations.
Especially when multiple events are badged, repeatedly calling the SSM Parameter API feels wasteful and adds a non-negligible amount of latency to several functions in the scale-up Lambda.