Skip to content

Conversation

@phene
Copy link
Contributor

@phene phene commented Jan 5, 2026

Description

Fixes bug in #4929 that assigned the type number to host_resource_group_arn instead of string.

@phene phene requested review from a team as code owners January 5, 2026 03:45
@phene phene force-pushed the fix-placement-group-host-resource-group-arn-type branch from 9d16c02 to f2cadfc Compare January 5, 2026 03:46
@phene phene changed the title Fixes runner_placement host_resource_group_arn type to be a string instead of a number fix: change runner_placement host_resource_group_arn type to be a string instead of a number Jan 5, 2026
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@edersonbrilhante do I remember correctly you introduced this. Looks to me a bug as well when checking the docs.

@edersonbrilhante
Copy link
Contributor

It is a bug indeed. Probably it was due a bad copy paste, when I set type number in partition_number. I remember going to aws provider repo to check the types in the go module for placement

I had fixed in my PR too #4930.

We can merge this PR and I rebase mine later

@npalm npalm merged commit 5405a04 into github-aws-runners:main Jan 13, 2026
41 checks passed
npalm pushed a commit that referenced this pull request Jan 13, 2026
🤖 I have created a release *beep* *boop*
---


##
[7.3.0](v7.2.0...v7.3.0)
(2026-01-13)


### Features

* add bypass-removal tag to prevent runner scale-down
([#4995](#4995))
([c0a9766](c0a9766))


### Bug Fixes

* cache GitHub App ID to reduce SSM calls
([#4994](#4994))
([0fb6f4a](0fb6f4a))
* change runner_placement host_resource_group_arn type to be a string
instead of a number
([#4979](#4979))
([5405a04](5405a04))
* **lambda:** bump the aws group in /lambdas with 7 updates
([#4985](#4985))
([5eacb0f](5eacb0f))
* **runners:** correct regex pattern for extracting AMI ID from SSM
parameter ARN
([#4981](#4981))
([174293c](174293c)),
closes
[#4959](#4959)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
Co-authored-by: github-aws-runners-pr|bot <github-aws-runners-pr[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants