Skip to content

Conversation

@wadherv
Copy link
Contributor

@wadherv wadherv commented Oct 19, 2025

Introducing a new variable parameter_store_tags to add tags for all the SSM Parameter Store resources created via Scale-Up and Pool lambda function.

@wadherv wadherv requested review from a team as code owners October 19, 2025 13:26
@wadherv wadherv marked this pull request as draft October 19, 2025 13:39
@wadherv wadherv marked this pull request as ready for review October 20, 2025 06:59
@npalm npalm requested a review from Copilot October 20, 2025 07:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for tagging AWS SSM Parameter Store parameters by adding a new parameter_store_tags variable that allows users to specify custom tags to be applied to all SSM parameters created by the Lambda functions.

  • Adds a new parameter_store_tags variable across all modules to accept user-defined tags
  • Updates Lambda functions to read and apply these tags when creating SSM parameters
  • Transforms the tag map into the required format for AWS SSM API calls

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
variables.tf Adds new parameter_store_tags variable definition at root level
modules/runners/variables.tf Adds parameter_store_tags variable to runners module
modules/runners/local.tf Creates local transformation to convert tag map to AWS format
modules/runners/scale-up.tf Passes transformed tags to scale-up Lambda environment
modules/runners/pool/ Updates pool module to handle parameter store tags
modules/multi-runner/ Adds parameter store tags support to multi-runner module
main.tf Passes parameter store tags variable to runners module
lambdas/ Updates Lambda functions to parse and apply tags to SSM parameters
README.md files Updates documentation to include new parameter store tags variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@npalm
Copy link
Member

npalm commented Oct 20, 2025

@wadherv thx for your PR, I wont have no option to check open PRs till the end of the month, sorry for the delay

@wadherv
Copy link
Contributor Author

wadherv commented Nov 2, 2025

@wadherv thx for your PR, I wont have no option to check open PRs till the end of the month, sorry for the delay

@npalm if you’ve got a moment, could you take a look at my PR? Would really appreciate it!

@wadherv wadherv requested a review from npalm November 2, 2025 14:31
@npalm
Copy link
Member

npalm commented Nov 2, 2025

Working my way to my backlog, thx for the reminder

@wadherv wadherv requested a review from npalm November 23, 2025 04:46
@npalm npalm changed the title feat(control-plane): [issue-4833] AWS SSM Parameter store tags feat(control-plane): tag controll plane created SSM Parameters (#4833) Nov 24, 2025
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wadherv tested the PR, and find a bug. The suggestion in locals.tf is address this. Bit wondering if we can check / validate the tags in anyway to avoid those errors.

@wadherv wadherv force-pushed the main branch 6 times, most recently from 4cb87ef to 3ac5bd9 Compare December 14, 2025 08:37
@npalm npalm self-assigned this Dec 15, 2025
@wadherv wadherv requested a review from npalm January 12, 2026 03:43
@npalm npalm changed the title feat(control-plane): tag controll plane created SSM Parameters (#4833) feat(control-plane): tag control plane created SSM Parameters (#4833) Jan 13, 2026
@Brend-Smits Brend-Smits requested a review from Copilot January 16, 2026 07:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brend-Smits
Copy link
Contributor

Brend-Smits commented Jan 16, 2026

I've reviewed the PR comments. Here's the status:

Comment 1 (modules/runners/pool/variables.tf:19 - type should be map(string)):
The current type string is actually correct. This variable receives the JSON-encoded value from local.parameter_store_tags (defined in modules/runners/local.tf line 2), which is a string representation of the tags array. Lambda environment variables must be strings, so this type definition is appropriate.

Comment 2 (lambdas/functions/control-plane/src/scale-runners/scale-up.ts:113 - validation rejects empty values):
This is a valid concern. AWS SSM Parameter Store does allow empty tag values, so the validation should be updated to permit them. I'll fix this now.

Edit: fixed it, now running tests.

Copy link
Contributor

@Brend-Smits Brend-Smits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spend some time testing this and it works as advertised. Happy to merge this. Great work and appreciate the patience!

@wadherv
Copy link
Contributor Author

wadherv commented Jan 20, 2026

@npalm can you also please approve this? I cannot merge this without your approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants