-
Notifications
You must be signed in to change notification settings - Fork 700
feat(control-plane): tag control plane created SSM Parameters (#4833) #4834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for tagging AWS SSM Parameter Store parameters by adding a new parameter_store_tags variable that allows users to specify custom tags to be applied to all SSM parameters created by the Lambda functions.
- Adds a new
parameter_store_tagsvariable across all modules to accept user-defined tags - Updates Lambda functions to read and apply these tags when creating SSM parameters
- Transforms the tag map into the required format for AWS SSM API calls
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variables.tf | Adds new parameter_store_tags variable definition at root level |
| modules/runners/variables.tf | Adds parameter_store_tags variable to runners module |
| modules/runners/local.tf | Creates local transformation to convert tag map to AWS format |
| modules/runners/scale-up.tf | Passes transformed tags to scale-up Lambda environment |
| modules/runners/pool/ | Updates pool module to handle parameter store tags |
| modules/multi-runner/ | Adds parameter store tags support to multi-runner module |
| main.tf | Passes parameter store tags variable to runners module |
| lambdas/ | Updates Lambda functions to parse and apply tags to SSM parameters |
| README.md files | Updates documentation to include new parameter store tags variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@wadherv thx for your PR, I wont have no option to check open PRs till the end of the month, sorry for the delay |
|
Working my way to my backlog, thx for the reminder |
npalm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wadherv tested the PR, and find a bug. The suggestion in locals.tf is address this. Bit wondering if we can check / validate the tags in anyway to avoid those errors.
4cb87ef to
3ac5bd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I've reviewed the PR comments. Here's the status: Comment 1 (modules/runners/pool/variables.tf:19 - type should be map(string)): Comment 2 (lambdas/functions/control-plane/src/scale-runners/scale-up.ts:113 - validation rejects empty values): Edit: fixed it, now running tests. |
Brend-Smits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spend some time testing this and it works as advertised. Happy to merge this. Great work and appreciate the patience!
|
@npalm can you also please approve this? I cannot merge this without your approval. |
Introducing a new variable
parameter_store_tagsto add tags for all the SSM Parameter Store resources created via Scale-Up and Pool lambda function.