⚡ Bolt: resolve concurrent test race conditions by isolating platform mocking - #264
⚡ Bolt: resolve concurrent test race conditions by isolating platform mocking#264nathanBurg wants to merge 3 commits into
Conversation
…ocking This commit introduces `platform` dependency injection into FileSystemService and ExecService interfaces to allow non-polluting, isolated platform mocking in tests. This resolves global state pollution and race conditions in concurrent test suites under Bun caused by mutating `process.platform` globally. Co-authored-by: nathanBurg <58287074+nathanBurg@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ocking This commit introduces `platform` dependency injection into FileSystemService and ExecService interfaces to allow non-polluting, isolated platform mocking in tests. This resolves global state pollution and race conditions in concurrent test suites under Bun caused by mutating `process.platform` globally, and fixes platform-agnostic mock paths on Windows runners by defaulting mock service platforms to "linux" (POSIX). Co-authored-by: nathanBurg <58287074+nathanBurg@users.noreply.github.com>
…ocking This commit introduces `platform` dependency injection into FileSystemService and ExecService interfaces to allow non-polluting, isolated platform mocking in tests. This resolves global state pollution and race conditions in concurrent test suites under Bun caused by mutating `process.platform` globally, and fixes platform-agnostic mock paths and command lookups on Windows runners by defaulting mock service platforms and lookup helpers to "linux" (POSIX). Co-authored-by: nathanBurg <58287074+nathanBurg@users.noreply.github.com>
1 participant
Resolves race conditions and global state pollution in concurrent test suites under Bun by adding explicit
platformmocking support in FileSystemService and ExecService, completely eliminating globalprocess.platformmutations in the agent definitions tests.PR created automatically by Jules for task 12506540904029057965 started by @nathanBurg