Skip to content

Port forwarding configuration#1309

Merged
Fredi-raspall merged 1 commit intomainfrom
pr/fredi/port-forwarding-config
Mar 3, 2026
Merged

Port forwarding configuration#1309
Fredi-raspall merged 1 commit intomainfrom
pr/fredi/port-forwarding-config

Conversation

@Fredi-raspall
Copy link
Contributor

On top of #1303

@Fredi-raspall Fredi-raspall requested a review from a team as a code owner March 2, 2026 19:23
@Fredi-raspall Fredi-raspall requested review from sergeymatov and removed request for a team March 2, 2026 19:23
@Fredi-raspall Fredi-raspall changed the base branch from main to pr/qmonnet/port-forwarding March 2, 2026 19:23
@Fredi-raspall Fredi-raspall requested review from qmonnet and removed request for sergeymatov March 2, 2026 19:24
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment on lines +28 to +30
let prefix = e.prefix();
let ports = e.ports();
(prefix, ports)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let prefix = e.prefix();
let ports = e.ports();
(prefix, ports)
(e.prefix(), e.ports())

Comment on lines +38 to +40
let prefix = e.prefix();
let ports = e.ports();
(prefix, ports)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@Fredi-raspall Fredi-raspall force-pushed the pr/qmonnet/port-forwarding branch from d54696f to 299bb7f Compare March 2, 2026 20:58
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/port-forwarding-config branch from 0bed637 to a0ccfd2 Compare March 2, 2026 20:59
Base automatically changed from pr/qmonnet/port-forwarding to main March 2, 2026 21:53
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/port-forwarding-config branch from a0ccfd2 to 26e9cfa Compare March 2, 2026 22:48
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/port-forwarding-config branch from 26e9cfa to 3c16e17 Compare March 2, 2026 22:51
@Fredi-raspall Fredi-raspall added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 0e1d422 Mar 3, 2026
20 checks passed
@Fredi-raspall Fredi-raspall deleted the pr/fredi/port-forwarding-config branch March 3, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants