fix(phase4): make Linux acceptance failures legible - #76
Merged
Conversation
Many Linux acceptance checks are bare `[[ ... ]]` or `--quiet` assertions that exit non-zero with no output. When one fails, the only signal is "Process completed with exit code 1" with no indication of which check failed, forcing a full candidate rerun to learn anything. Add an ERR trap that prints the exact line number and failing command as a GitHub error annotation, so a failing candidate is diagnosable from the log alone. No behavior change on success; existing guarded checks keep their own messages. Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Linux acceptance script now reports the failing line, exit status, and Bash command when a command fails. ChangesLinux acceptance diagnostics
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an ERR trap to ops/platform-acceptance/linux.sh so a failing silent assertion reports its exact line and command instead of a bare exit code. No behavior change on success. Full CI green locally. No release/tag/production change.
Summary by CodeRabbit