feat(desktop): add setting to disable PR stack footer#14637
Open
swushi wants to merge 1 commit into
Open
Conversation
Adds a Reviews.enableStackFooter setting (default true) that gates the GitButler stack list footer appended to PR/MR descriptions. Exposed as a toggle in integration settings and honored at every footer writer: PR creation and stack/branch drag operations.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Reviews.enableStackFooter setting (defaulting to true) that allows users of the desktop app to opt out of GitButler’s automatic PR/MR stack footer updates, with a corresponding UI toggle in Integration settings.
Changes:
- Added
enableStackFooterto the RustReviewssettings model, defaults, update API, and testsupport defaults. - Regenerated the but-sdk TypeScript types to expose
Reviews.enableStackFooter. - Gated PR/MR stack footer updates in desktop flows (PR creation + stack/branch drag-drop) behind the new setting, and added a UI toggle to control it.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/but-sdk/src/generated/linear/index.d.ts | Exposes Reviews.enableStackFooter in generated SDK typings. |
| packages/but-sdk/src/generated/graph/index.d.ts | Exposes Reviews.enableStackFooter in generated SDK typings. |
| crates/but-testsupport/src/sandbox.rs | Ensures test sandbox settings include enable_stack_footer: true. |
| crates/but-settings/src/app_settings.rs | Adds the new enable_stack_footer field to Reviews settings schema. |
| crates/but-settings/src/api.rs | Adds enable_stack_footer to ReviewsUpdate and applies it in update_reviews(). |
| crates/but-settings/assets/defaults.jsonc | Sets reviews.enableStackFooter default to true. |
| apps/desktop/src/lib/dragging/dropHandlers/stackDropHandler.ts | Stops updating stack PR descriptions when the setting is disabled. |
| apps/desktop/src/lib/dragging/dropHandlers/branchDropHandler.ts | Stops updating stack PR descriptions when the setting is disabled. |
| apps/desktop/src/components/settings/IntegrationsSettings.svelte | Adds the “Add GitButler stack footer…” toggle wired to updateReviews(). |
| apps/desktop/src/components/forge/ReviewCreation.svelte | Gates initial stack footer writing after PR creation behind the setting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧢 Changes
Reviews.enableStackFootersetting (defaulttrue) to the Rust settings layer☕️ Reasoning
The GitButler stack footer was always appended to PR/MR descriptions with no way to opt out, which conflicts with users who maintain their own repo-specific stack-list tooling. Rather than a one-off flag, I added it to the existing
Reviewssettings group. It defaults to enabled to preserve current behavior.🎫 Affected issues
Fixes: #14282