Add support for rounded rectangles in Masters#1460
Open
benjaminclot wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds runtime recognition for rounded-rectangle objects in slide masters so master definitions can create roundRect shapes.
Changes:
- Adds
roundRectto theMASTER_OBJECTSenum. - Handles
roundRectincreateSlideMasterviaSHAPE_TYPE.ROUNDED_RECTANGLE.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/core-enums.ts |
Extends recognized master object keys with roundRect. |
src/gen-objects.ts |
Adds slide-master object handling for rounded rectangles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else if (MASTER_OBJECTS[key] && key === 'image') addImageDefinition(tgt, object[key]) | ||
| else if (MASTER_OBJECTS[key] && key === 'line') addShapeDefinition(tgt, SHAPE_TYPE.LINE, object[key]) | ||
| else if (MASTER_OBJECTS[key] && key === 'rect') addShapeDefinition(tgt, SHAPE_TYPE.RECTANGLE, object[key]) | ||
| else if (MASTER_OBJECTS[key] && key === 'roundRect') addShapeDefinition(tgt, SHAPE_TYPE.ROUNDED_RECTANGLE, object[key]) |
| else if (MASTER_OBJECTS[key] && key === 'image') addImageDefinition(tgt, object[key]) | ||
| else if (MASTER_OBJECTS[key] && key === 'line') addShapeDefinition(tgt, SHAPE_TYPE.LINE, object[key]) | ||
| else if (MASTER_OBJECTS[key] && key === 'rect') addShapeDefinition(tgt, SHAPE_TYPE.RECTANGLE, object[key]) | ||
| else if (MASTER_OBJECTS[key] && key === 'roundRect') addShapeDefinition(tgt, SHAPE_TYPE.ROUNDED_RECTANGLE, object[key]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Support for rounded rectangles in Masters.
Change Description
'roundRect'to theMASTER_OBJECTSenum insrc/core-enums.ts, enabling recognition of the new master object type.createSlideMasterfunction insrc/gen-objects.tsto handleroundRectby callingaddShapeDefinitionwithSHAPE_TYPE.ROUNDED_RECTANGLE.Change Type
Motivation and Context
Adding rounded rectangles simply by adding a
rectRadiuson a standardrectin a Master doesn't work.