Skip to content

Report stalled concurrent occurrence lifecycle stages - #879

Merged
flyingrobots merged 2 commits into
mainfrom
fix/concurrent-occurrence-timeout
Sep 7, 2026
Merged

Report stalled concurrent occurrence lifecycle stages#879
flyingrobots merged 2 commits into
mainfrom
fix/concurrent-occurrence-timeout

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Sep 7, 2026

Copy link
Copy Markdown
Member

The concurrent-occurrence test in #878 timed out without identifying whether runtime opening, lane setup, admission, or cleanup stalled. Report each public lifecycle stage only when the test fails, preserving every existing behavioral assertion and the 60-second limit. This supplies evidence for the next occurrence. The root cause tracked in #878 remains unresolved and blocks release #876.

Change kind: test diagnostics, plus the development-only @humanfs/node security update required by the locked release audit (GHSA-p498-v437-472g, also prepared in #877).

Validation: an injected stalled close was observed red and named close writer-b: pending while retaining completed opening and admission stages. The ordinary five-test file, normal pre-push gates, locked audit, and exact-head Node 22 CI all passed. Manual SSJS review is green; diagnostic state is test-owned and adds no production host dependency or cast.

The original timeout remains unreproduced. Disposable Linux arm64 probes on Node 22.23.2/Git 2.55.0 covered the baseline, five idle-retirement schedules, 24 payload cases, and one-shot failures of four Git protocols. These bounded probes passed or rejected with completed cleanup. They are not an exhaustive schedule search or an identical reproduction of the Ubuntu 24.04 x64 runner.

Update @humanfs/node to 0.16.8 and its required core/types packages for GHSA-p498-v437-472g. The locked audit reports zero vulnerabilities. Refs #876.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 9f79eddd-d018-4242-ad9a-6cfd2729d819

📥 Commits

Reviewing files that changed from the base of the PR and between 68c3b8b and 699c2b0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • test/integration/application/Runtime.entityOccurrence.integration.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 19.1.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm package payload: passed
  • jsr publish dry-run: passed

If this PR is from a release/* branch and merges to main, Main Push Release Branch Check will run final preflight and create v19.1.0. A maintainer who is a JSR @git-stunts scope member must then dispatch the Release workflow manually.

@flyingrobots flyingrobots changed the title Diagnose concurrent entity occurrence timeouts Report stalled concurrent occurrence lifecycle stages Sep 7, 2026
@flyingrobots
flyingrobots marked this pull request as ready for review September 7, 2026 19:25
@flyingrobots
flyingrobots merged commit 2fb3e6e into main Sep 7, 2026
22 checks passed
@flyingrobots
flyingrobots deleted the fix/concurrent-occurrence-timeout branch September 7, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant