Skip to content

Conversation

@jovnc
Copy link
Collaborator

@jovnc jovnc commented Jan 30, 2026

Exercise Review

Exercise Discussion

Fixes #254

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested your changes using the instructions posted?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@github-actions
Copy link

Hi @jovnc, thank you for your contribution! 🎉

This PR comes from your fork jovnc/exercises on branch feat/enhance-mix-messy-docs.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "jovnc",
        "repository": "exercises",
        "branch": "feat/enhance-mix-messy-docs"
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

  • (For exercises and hands-ons) I have verified that the downloading behavior works
  • (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

Copy link
Contributor

@desmondwong1215 desmondwong1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@jovnc jovnc requested a review from desmondwong1215 February 4, 2026 15:57
@jovnc
Copy link
Collaborator Author

jovnc commented Feb 4, 2026

@desmondwong1215 and others ready for review again, thanks for the review!

Should now also detect that branch isn't created from v1.0 tag commit now.

@desmondwong1215
Copy link
Contributor

LGTM! Tested and it works as expected.

@jovnc
Copy link
Collaborator Author

jovnc commented Feb 5, 2026

Thanks @desmondwong1215 Will merge this in now!

@jovnc jovnc merged commit 5f3c511 into git-mastery:main Feb 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve verify logic of T6L5/mix-messy-docs

2 participants