Fix Permission Error [WinError32] during cleanup

[desmondwong1215]

Fix #252

I have tested it using WSL (it also works before these changes), PowerShell, and Git Bash. It works for me.

[github-actions]

Hi @desmondwong1215, thank you for your contribution! 🎉

This PR comes from your fork desmondwong1215/exercises on branch fix/clean-up.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "desmondwong1215",
        "repository": "exercises",
        "branch": "fix/clean-up"
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

• (For exercises and hands-ons) I have verified that the downloading behavior works
• (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

[Copilot]

Pull request overview

This PR addresses a PermissionError (WinError 32) that occurs on Windows when cleaning up temporary directories containing Git repositories. The issue stems from Windows file locking behavior where open file handles and the current working directory prevent deletion of the temporary directory.

Changes:

• Added explicit repo.close() calls for Git repository objects before cleanup
• Changed working directory to parent of temp directory before attempting cleanup
• Reordered cleanup sequence to close repos → exit contexts → change directory → cleanup temp directories

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jovnc]

@desmondwong1215 On the app side, we likely also want to give an appropriate error/warning message to the user

[desmondwong1215]

Yeah, I will add an error/warning message to the user when fixing this issue on the app side.

[jovnc]

rs is used for testing only, is this related to the bug?

[desmondwong1215]

When we try to clean up the temporary directory on line 224 (self.__temp_dir.cleanup()), Windows can't delete it because the Git repository objects still have open file handles.

[jovnc]

LGTM! Thanks for the work!