fix(server): correct COTP connection confirm framing - #816
Open
gijzelaerr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TPDU-size negotiation added for #804 is correct and remains intact. However, the Connection Confirm also emitted a standalone CDT byte even though class-0 CDT is already encoded in the low nibble of the CC type byte. That shifted every following field and made the frame malformed for strict clients such as Apache PLC4X.
This removes only the extra byte, keeps the negotiated TPDU-size parameter, and adds an exact-frame regression test that also verifies the COTP length indicator.
Local verification:
Closes #813