Add symbolic addressing (read/write by tag name)#638
Open
gijzelaerr wants to merge 2 commits intomasterfrom
Open
Add symbolic addressing (read/write by tag name)#638gijzelaerr wants to merge 2 commits intomasterfrom
gijzelaerr wants to merge 2 commits intomasterfrom
Conversation
Closes #616 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move getter/setter dispatch maps to module-level constants to avoid rebuilding them on every read/write call - Move set_lword from _INT_SETTER_MAP to _SIMPLE_SETTER_MAP so its value is not cast through int() redundantly - Fix read_many docstring to honestly describe individual reads instead of claiming batched/grouped behavior - Extract _read_source() helper for from_csv/from_json that checks for newlines before falling back to filesystem path detection, preventing inline content from accidentally matching an existing file - Document get_word type annotation mismatch (returns int at runtime despite bytearray annotation in getters.py) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gijzelaerr
force-pushed
the
feature/symbolic-addressing
branch
from
0587564 to
bcdbf0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds SymbolTable class for read/write by tag name. Closes #616.