feat(chart): podLabels on the chart's pods - #55
Draft
QuentinBisson wants to merge 2 commits into
Draft
QuentinBisson wants to merge 2 commits into
QuentinBisson wants to merge 2 commits into
Conversation
A multi-tenant telemetry collector commonly takes a pod's tenant from a pod label, the one signal a headerless OTLP export carries. The chart sets only its own `app` label on every pod and offers no way to add one. `podLabels` is added to every long-running pod template, next to `app`, which it cannot replace: `app` is the selector of every workload, so the render fails when podLabels sets it. The rustfs-bucket-init Job is left out, because a Job's pod template is immutable and a label change would fail the upgrade. The default render is unchanged, so manifests/ate-install/ stays as is. Signed-off-by: QuentinBisson <quentin@giantswarm.io> (cherry picked from commit 095ae30)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Substrate's OTLP export reaches no tenant (giantswarm/giantswarm#36711). The OTLP gateway takes the tenant from the pod label
observability.giantswarm.io/tenantwhen an export carries no header. The chart has no pod-label key and no OTLP headers key, so every Substrate span, metric and log is dropped as tenant-less.Change
Cherry-pick of kagent-dev#48, plus its
FORK.mdrow.podLabelsgoes on every long-running pod next toapp, which it cannot replace. Therustfs-bucket-initJob does not get it, because its pod template is immutable. The default render is unchanged (make verify-helm-template,helm unittest43/43). Rebase-merge: the ledger row names the pre-merge SHAb05a7fbc, so the next ledger update corrects it. This ships in1.1.0with the re-pin; the agent-platform side is a separate PR.