Skip to content

fix(row-detail): auto-select overlay for transformed rows - #2776

Open
ghiscoding wants to merge 1 commit into
masterfrom
bugfix/auto-detect-overlay
Open

fix(row-detail): auto-select overlay for transformed rows#2776
ghiscoding wants to merge 1 commit into
masterfrom
bugfix/auto-detect-overlay

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

Automatically use Row Detail overlay rendering when rowTopOffsetRenderType is set to transform, removing the need to explicitly configure renderMode: 'overlay'.

Why

Transform positioning is the default grid behavior, and overlay rendering is the compatible Row Detail renderer. This simplifies configuration while preserving the legacy inline compatibility path.

Changes

  • Auto-detect transformed row positioning and use overlay rendering when renderMode is omitted.
  • Preserve explicit renderMode: 'inline' behavior with top-based row positioning.
  • Document renderMode as a temporary transition option.
  • Update shared and framework-specific Row Detail documentation.
  • Remove redundant overlay settings from demos.
  • Add tests for automatic overlay and inline fallback behavior.

Validation

  • 504 focused Vitest tests passed.
  • Common and Row Detail plugin TypeScript checks passed.
  • pnpm lint passed.
  • pnpm prettier:check passed.
  • git diff --check passed.

Comments

No issue number provided.

AI / LLM assistance

  • AI / LLM assistance used:
    • No
    • Yes
  • If Yes:
    • which tool/model: Codex GPT-5.6 Terra
    • how was it used: Reviewed the existing implementation, updated source/tests/documentation, and ran validation checks.

Checklist

  • The changes are limited to only one scope.
  • Tests were added or updated where appropriate.
  • Documentation was updated where appropriate.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (77f0ded) to head (4682a2a).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2776   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         199      199           
  Lines       25763    25765    +2     
  Branches     9128     9130    +2     
=======================================
+ Hits        25763    25765    +2     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2776

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2776

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2776

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2776

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2776

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2776

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2776

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2776

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2776

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2776

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2776

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2776

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2776

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2776

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2776

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2776

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2776

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2776

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2776

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2776

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2776

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2776

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2776

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2776

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2776

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2776

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2776

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2776

commit: 4682a2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant