feat(export): add opt-in includeColumnWidth for Excel and PDF exports - #2697
Open
ghiscoding wants to merge 7 commits into
Open
feat(export): add opt-in includeColumnWidth for Excel and PDF exports#2697ghiscoding wants to merge 7 commits into
ghiscoding wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2697 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 200 200
Lines 25465 25502 +37
Branches 8999 9019 +20
=======================================
+ Hits 25465 25502 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
cc @jr01 you probably want to be aware of this feature/change since you're using the PDF Export. The summary is that I recently added variable row height and also in Excel/PDF exports, I figured that we should also add the column width as well but as opt-in. We now have 2 new options:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/sql
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
@slickgrid-universal/web-mcp
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vibe coded with Copilot using GPT-5.3-Codex
after recently adding variable row height in Excel/PDF exports, I figured that we should also add the column width as well but as opt-in.
Why
Exports were already handling row height fidelity, but column width fidelity was inconsistent:
This change introduces an explicit, safe way to export using grid column widths without breaking current behavior.
What changed (behavior)
A new option is introduced for both Excel and PDF:
When includeColumnWidth is false:
When includeColumnWidth is true:
Width resolution precedence is now explicit:
In plain terms:
Why opt-in
This is intentionally opt-in for backward compatibility:
Notes on units
Scope details
Validation
Summary
We now have 2 new options in Excel/PDF exports for row height and column width:
includeVariableRowHeight=> default true but only when variable row height is enabledincludeColumnWidth=> default false (opt-in)Export Demo