Repository navigation
Conversation
Add `python3 -m taskbroker_client.healthcheck <path>`, which removes the health file the worker touches, or exits 1 with a one-line message if it is missing. Pods currently run `rm <path>`, which does not work on distroless images that have no shell or rm. The worker writes the file, so the client should own the check. The path is required because neither the client nor sentry has a default; ops passes it per pool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
evanh
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
python3 -m taskbroker_client.healthcheck <path>. It removes the health file the worker touches, so the next probe fails unless the worker touches it again. If the file is already missing, it exits 1 with one line:getsentry is moving to a distroless image, and the taskworker liveness probe (
rm /tmp/health) needsrm. The ops PR (getsentry/ops#24151) works around it with an inlinepython3 -csnippet. The worker writes this file, so the client should own the check too, like the drain command in #810.The path is required. Neither the client nor
sentry run taskworkerhas a default, and ops passes it per pool. The module imports onlyargparse, because the probe runs every few seconds on every worker.Nothing waits on this. Once it's released and in the sentry image, ops can replace the inline snippet.
Refs SEC-1112