Repository navigation
fix(slack): remove bold formatting inside link text - #127928
Open
abdullah129026 wants to merge 1 commit into
Open
abdullah129026 wants to merge 1 commit into
abdullah129026 wants to merge 1 commit into
Conversation
Slack's Android app does not render links that contain mrkdwn formatting. Alert titles were built as <url|*title*>, which showed as plain text on mobile. Emit <url|title> instead. Fixes getsentry#109694
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack's Android app doesn't render links that have mrkdwn formatting inside them. Our alert titles were built as <url|title>, so on mobile they showed up as plain text instead of links. Desktop handled it fine, which is why nobody noticed sooner.
This removes the bold markers from inside the links in the issue alert, metric alert, incident alert, and notification digest builders. Titles still show, they just aren't bold inside the link anymore. Titles without a link keep their bold.
Updated the existing test assertions that encoded the old format.
Fixes #109694