Repository navigation
Conversation
Wrap the rotating ring in a stationary clipping container so its transformed bounds cannot change ancestor scroll heights. Inset the ring by 0.5px to leave room for antialiasing while preserving the outer dimensions. Keep messages outside the clip and mini positioning on the wrapper. Update the profiling border selector and use the size prop for the onboarding spinner.
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-czno732b5.sentry.dev |
jamieQ
marked this pull request as ready for review
October 16, 2026 16:28
NicoHinderling
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix some "jumpiness" when autofix data is loading. Here's a synthetic before/after showing the motivation:
jumpy-before.mov
calm-after.mov
Root cause IIUC is that the animating spinner's bounding box changes size during the transform, which makes scroll view offset/size calculations change (which is the cause of the jitter). Proposed fix was to hide the overflow for the spinning component (because it is sometimes laid out with text next to it, a new wrapper was added). Also got a little side-tracked trying to ensure the spinner circle doesn't have visible clipping of the anti-aliased pixels, which resulted in shrinking it by a small amount.
Refs AIML-3655