Skip to content

fix(ui): Contain loading indicator animation overflow - #127791

Open
jamieQ wants to merge 1 commit into
masterfrom
fix/autofix-spinner-overflow
Open

jamieQ wants to merge 1 commit into
masterfrom
fix/autofix-spinner-overflow

Conversation

@jamieQ

@jamieQ jamieQ commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Attempt to fix some "jumpiness" when autofix data is loading. Here's a synthetic before/after showing the motivation:

Before After
jumpy-before.mov
calm-after.mov

Root cause IIUC is that the animating spinner's bounding box changes size during the transform, which makes scroll view offset/size calculations change (which is the cause of the jitter). Proposed fix was to hide the overflow for the spinning component (because it is sometimes laid out with text next to it, a new wrapper was added). Also got a little side-tracked trying to ensure the spinner circle doesn't have visible clipping of the anti-aliased pixels, which resulted in shrinking it by a small amount.

Refs AIML-3655

Wrap the rotating ring in a stationary clipping container so its transformed
bounds cannot change ancestor scroll heights. Inset the ring by 0.5px to
leave room for antialiasing while preserving the outer dimensions.

Keep messages outside the clip and mini positioning on the wrapper. Update
the profiling border selector and use the size prop for the onboarding spinner.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Story previews

Preview the stories changed in this PR on the Vercel deployment:

Preview deployment: https://sentry-czno732b5.sentry.dev

@jamieQ
jamieQ marked this pull request as ready for review October 16, 2026 16:28
@jamieQ
jamieQ requested review from a team as code owners October 16, 2026 16:28

This branch was successfully deployed

1 active deployment
Preview — c33fcab6 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants