Repository navigation
Conversation
RetryException.__str__ returned force_bytes(...), so str(exception) raised TypeError: __str__ returned non-string (type bytes). Anything that formats the exception, such as a logging call with %s, failed instead of showing the retry message. Return force_str(...) so the message is rendered as text, with undecodable bytes replaced as before.
joshuarli
force-pushed
the
fix/retry-exception-str
branch
from
October 16, 2026 16:21
dd6120f to
dce933b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryException.__str__returnedforce_bytes(self.message, errors="replace"), sostr(exception)raisedTypeError: __str__ returned non-string (type bytes). Anything that formats the exception, such as a logging call with%s, hit that error instead of printing the retry message. It now returnsforce_str(...), and a bytes message is still decoded with replacement.TimedRetryPolicyis the only raiser in this repo and its message is already astr, so the visible change is that formatting the exception works.