Repository navigation
feat(lint): Enable typescript/no-generated-empty-object-type - #127785
Merged
Merged
Conversation
scttcper
added this pull request to stack #127776
October 16, 2026 15:57
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
scttcper
removed this pull request from stack #127776
October 16, 2026 16:08
scttcper
added this pull request to stack #127787
October 16, 2026 16:08
Contributor
Sentry Snapshot Testing
|
Base automatically changed from
scttcper/enable-react-incompatible-library
to
master
October 16, 2026 16:31
scttcper
force-pushed
the
scttcper/enable-no-generated-empty-object-type
branch
from
October 16, 2026 16:31
f3058d9 to
a03eba5
Compare
New in oxlint 1.86, flags types that quietly resolve to `{}`. The one
hit was `Readonly<ValidateColumnTypes>` on discover aggregate
parameters, which mapped the predicate half of the union to `{}` so
`columnTypes` accepted anything.
Applying `readonly` to the array only turned up the detector spans
config wrapping apdex's predicate in an array, where it would never be
called. It now adapts the predicate to the discover signature instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
force-pushed
the
scttcper/enable-no-generated-empty-object-type
branch
from
October 16, 2026 16:39
a03eba5 to
b50776a
Compare
scttcper
marked this pull request as ready for review
October 16, 2026 16:49
evanpurkhiser
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New in oxlint 1.86,
typescript/no-generated-empty-object-typeflags types that quietly resolve to{}. The one hit wasReadonly<ValidateColumnTypes>on discover aggregate parameters, which turned the predicate half of the union into{}, socolumnTypesaccepted anything.Applying
readonlyto just the array turned up the detector spans config wrapping apdex's predicate in an array, where nothing would ever call it. It now adapts the predicate to the discover signature instead.https://oxc.rs/docs/guide/usage/linter/rules/typescript/no-generated-empty-object-type