Repository navigation
feat(lint): Enable react/incompatible-library and react/void-use-memo - #127775
Merged
Merged
Conversation
scttcper
added this pull request to stack #127776
October 16, 2026 15:33
github-actions
Bot
added
the
Scope: Frontend
`react/todo` reports where the React Compiler bails out, like `try`/`finally` without a `catch`. When it bails, the other compiler rules stop checking that component, so this makes the gaps visible and keeps new ones out. The 109 existing findings across 82 files go into the suppression baseline instead of getting fixed here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The React Compiler skips any component or hook that suppresses a React hooks rule, which also turns off the other compiler rules there. All of the existing hits are old `eslint-disable react-hooks/exhaustive-deps` comments. The 91 existing findings across 77 files go into the suppression baseline, so only new suppressions fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`react/incompatible-library` flags hooks from libraries that break memoization, like TanStack Virtual. The one existing hit in `useVirtualRows` goes into the incubator baseline. `react/void-use-memo` catches `useMemo` callbacks that return nothing. No existing hits, so it's just on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
force-pushed
the
scttcper/enable-react-incompatible-library
branch
from
October 16, 2026 15:37
35be085 to
7efab67
Compare
Contributor
Sentry Snapshot Testing
|
Moves `react/todo` out of the incubator and back to a regular rule. The 109 existing findings get `oxlint-disable-next-line` comments instead of suppression budgets, so they're visible where the compiler bails out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… scttcper/enable-react-rule-suppression # Conflicts: # oxlint-suppressions.json # oxlint.config.ts
…dings Moves `react/rule-suppression` out of the incubator and back to a regular rule. Each of the 91 old `eslint-disable react-hooks/exhaustive-deps` comments gets an `oxlint-disable-next-line` above it instead of a suppression budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ession' into scttcper/enable-react-incompatible-library # Conflicts: # oxlint-suppressions.json # oxlint.config.ts
Moves `react/incompatible-library` out of the incubator and back to a regular rule. The one hit in `useVirtualRows` gets an `oxlint-disable-next-line` comment instead of a suppression budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It flags every `exhaustive-deps` suppression in either comment spelling, so keeping it on just stacks an extra ignore above all 91 existing ones. Removes those comments and leaves the rule off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ession' into scttcper/enable-react-incompatible-library
scttcper
removed this pull request from stack #127776
October 16, 2026 16:08
scttcper
changed the base branch from
scttcper/enable-react-rule-suppression
to
scttcper/enable-react-todo
October 16, 2026 16:08
scttcper
added this pull request to stack #127787
October 16, 2026 16:08
…ct-incompatible-library
scttcper
marked this pull request as ready for review
October 16, 2026 16:14
evanpurkhiser
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on the last two React Compiler rules we had off.
react/incompatible-libraryflags hooks from libraries that break memoization, like TanStack Virtual'suseVirtualizer. The one existing hit inuseVirtualRowsgets an inline ignore, and the old TODO comment goes away.react/void-use-memocatchesuseMemocallbacks that don't return anything. No existing hits, so it's just on.