Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Frontend
scttcper
added this pull request to stack #127776
October 16, 2026 15:33
The React Compiler skips any component or hook that suppresses a React hooks rule, which also turns off the other compiler rules there. All of the existing hits are old `eslint-disable react-hooks/exhaustive-deps` comments. The 91 existing findings across 77 files go into the suppression baseline, so only new suppressions fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
force-pushed
the
scttcper/enable-react-rule-suppression
branch
from
October 16, 2026 15:37
95da045 to
7deca12
Compare
Contributor
Sentry Snapshot Testing
|
… scttcper/enable-react-rule-suppression # Conflicts: # oxlint-suppressions.json # oxlint.config.ts
…dings Moves `react/rule-suppression` out of the incubator and back to a regular rule. Each of the 91 old `eslint-disable react-hooks/exhaustive-deps` comments gets an `oxlint-disable-next-line` above it instead of a suppression budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
changed the title
It flags every `exhaustive-deps` suppression in either comment spelling, so keeping it on just stacks an extra ignore above all 91 existing ones. Removes those comments and leaves the rule off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
removed
the
Scope: Frontend
scttcper
removed this pull request from stack #127776
October 16, 2026 16:08
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React Compiler skips any component or hook that suppresses a React hooks rule, and that also turns off the other compiler rules there. Every existing hit is an old
eslint-disable react-hooks/exhaustive-depscomment. Ouroxlint-disable react/*comments aren't flagged.The 91 existing hits get an
oxlint-disable-next-line react/rule-suppressionabove them, so only new suppressions fail.