Repository navigation
fix(replays): Return 404 for malformed replay IDs in endpoints - #127764
Open
sentry-junior[bot] wants to merge 5 commits into
Open
sentry-junior[bot] wants to merge 5 commits into
sentry-junior[bot] wants to merge 5 commits into
Conversation
…t index Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
github-actions
Bot
added
the
Scope: Backend
gggritso
marked this pull request as draft
October 16, 2026 14:47
Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
…se endpoint Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
sentry-junior
Bot
changed the title
Co-Authored-By: George Gritsouk <george.gritsouk@sentry.io>
gggritso
reviewed
Oct 16, 2026
Member
|
@cursor review |
gggritso
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit edb92da. Configure here.
gggritso
marked this pull request as ready for review
October 16, 2026 16:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay endpoints generally return a 404 when an invalid replay ID is sent it, but some of them return 500. First of all that's not correct, second of all it's not consistent, and third of all it fires a bunch of alerts for 50x on endpoints which is not useful!
Instead, let's just return 404 everywhere by mashing that check into
convert_args.via George Gritsouk.
--
View Junior Session [Sentry]