Repository navigation
Conversation
find_installation_by_proxy_user loaded the sentry app and installation, then serialization lazy loaded app.application and installation.api_token as separate queries. select_related both so it's two queries instead of up to four. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eager load the sentry app's application and the installation's api token in
find_installation_by_proxy_user, serialization was lazy loading both as separate queries.This RPC runs about 141M times a week (any API request using a sentry app token) at ~24ms p50. The application lookup ran ~166M times a week on the control db, most of it from here. Example trace, the third query under the RPC handler is the application lookup that goes away.