Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 40669b5. Configure here.
scttcper
approved these changes
Oct 15, 2026
kcons
marked this pull request as ready for review
October 16, 2026 00:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was 'base' because at the beginning, that file held the core of the action log fuctionality.
Since then, everything else has been moved out, and now 'base' just holds request parsing logic, and due to init.py inclusion, we end up adding the dependencies for that to anything interacting with publishing or parsing.
This fixes that by calling the module for extracting data from requests 'request', and requiring it to be imported directly.
Also moved the ApiClient singleton into sentry.api.client so mypy no longer confuses it with the module of the same name, otherwise typing fails.