Repository navigation
Conversation
No callsite uses fetchMutation any more, so delete it and its ApiMutationVariables type, and point the form docs, the data-fetching and form agent skills, and the Client.request deprecation notes at apiFetch. The doc examples now read the body from response.json.
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-ky8guu3vh.sentry.dev |
Contributor
Sentry Snapshot Testing
Base commit |
…-mutations-cleanup
…-mutations-cleanup
…-mutations-cleanup
…-mutations-cleanup
…-mutations-cleanup
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
fetchMutationand itsApiMutationVariablestype fromsentry/utils/queryClientnow that no callsite uses it, and points the docs atapiFetch: the form.mdxpages, thefrontend-data-fetching/generate-frontend-forms/migrate-frontend-formsagent skills, and the@deprecatednotes onClient.request/requestPromise(which also named afetchDataQueryhelper that no longer exists). The doc examples now showonSuccessreadingresponse.json.Depends on #127699 and all area PRs: #127700, #127701, #127702, #127703, #127704. Until they merge, this PR targets an integration branch that combines them, so its diff shows only the cleanup; it will be retargeted to
masteronce they land.develop-docs/frontend/network-requests.mdxingetsentry/sentry-docsalso mentionsfetchMutationand needs a follow-up there.No feature flags. No UI changes, so no screenshots.