Repository navigation
Conversation
|
This PR has a migration; here is the generated SQL for for --
-- Alter field monitor on monitorcheckin
--
SET CONSTRAINTS "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id" IMMEDIATE; ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id";
ALTER TABLE "sentry_monitorcheckin" ALTER COLUMN "monitor_id" DROP NOT NULL;for --
-- Remove index sentry_moni_monitor_0a49ce_idx from monitorcheckin
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_moni_monitor_0a49ce_idx";
--
-- Remove index sentry_moni_monitor_7ed5ce_idx from monitorcheckin
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_moni_monitor_7ed5ce_idx";
--
-- Moved monitorcheckin.monitor field to pending deletion state
--
-- (no-op)for --
-- Remove field monitor from monitorcheckin
--
SET CONSTRAINTS "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id" IMMEDIATE; ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id";
ALTER TABLE "sentry_monitorcheckin" DROP COLUMN "monitor_id" CASCADE; |
e2d1a7b to
56da090
Compare
f03dfbf to
aacd7de
Compare
Sentry Snapshot Testing
|
|
This PR has a migration; here is the generated SQL for for --
-- Alter field monitor on monitorcheckin
--
SET CONSTRAINTS "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id" IMMEDIATE; ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id";
ALTER TABLE "sentry_monitorcheckin" ALTER COLUMN "monitor_id" DROP NOT NULL;for --
-- Remove index sentry_moni_monitor_0a49ce_idx from monitorcheckin
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_moni_monitor_0a49ce_idx";
--
-- Remove index sentry_moni_monitor_7ed5ce_idx from monitorcheckin
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_moni_monitor_7ed5ce_idx";
--
-- Moved monitorcheckin.monitor field to pending deletion state
--
-- (no-op)for --
-- Remove field monitor from monitorcheckin
--
SET CONSTRAINTS "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id" IMMEDIATE; ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorcheckin_monitor_id_c15ff0f0_fk_sentry_monitor_id";
ALTER TABLE "sentry_monitorcheckin" DROP COLUMN "monitor_id" CASCADE; |
cbcb40b to
c28d830
Compare
ebd7a93 to
54b6930
Compare
c28d830 to
1c90d7b
Compare
54b6930 to
6b3b604
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Remove index sentry_moni_monitor_0a49ce_idx from monitorcheckin
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_moni_monitor_0a49ce_idx";
--
-- Remove index sentry_moni_monitor_7ed5ce_idx from monitorcheckin
--
DROP INDEX CONCURRENTLY IF EXISTS "sentry_moni_monitor_7ed5ce_idx";
--
-- Moved monitorcheckin.monitor field to pending deletion state
--
-- (no-op)for --
-- Remove field monitor from monitorcheckin
--
ALTER TABLE "sentry_monitorcheckin" DROP COLUMN "monitor_id" CASCADE; |
1c90d7b to
c4aabd8
Compare
6b3b604 to
abf49fc
Compare
Part of a series reducing crons database work per check-in, as check-in volume grows. Drops `sentry_monitorcheckin.monitor_id`. Its indexes were dropped in the previous PR. `DROP COLUMN` only changes the catalog, so it is quick. Co-Authored-By: Claude <noreply@anthropic.com>
31723e3 to
28b7f49
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Remove field monitor from monitorcheckin
--
ALTER TABLE "sentry_monitorcheckin" DROP COLUMN "monitor_id" CASCADE; |
Part of a series reducing crons database work per check-in, as check-in volume grows.
Drops
sentry_monitorcheckin.monitor_id. Its indexes are dropped in #127646.DROP COLUMNonly changes the catalog, so it is quick.Do not merge until #127646 has deployed. Dropping the column while older code still has the field on the model would break it.
Merge order:
monitor_idand make it nullable with no FK constraintMOVE_TO_PENDING(after ref(crons): Stop using monitor_id on check-ins #127644 deploys)DELETE(after 3 deploys and its migration has run) ← this PR