Repository navigation
feat(explore): Add descriptions for all dropped-event reasons - #127629
manessaraj wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| usage_exceeded: { | ||
| title: t('Quota exceeded'), | ||
| short: dataType => | ||
| dataType |
There was a problem hiding this comment.
For descriptions like this, dataType can be required and we don't need to have the optional non-dynamic string
| before_send: { | ||
| title: t('Dropped by before send'), | ||
| short: t('Event dropped by your before send function.'), | ||
| long: t( |
There was a problem hiding this comment.
As spoken in dms, long is no longer needed
Refs DAIN-1937
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 512acd1. Configure here.
| return ( | ||
| <SimpleTable.FullWidthRow> | ||
| <Flex | ||
| align="center" |
There was a problem hiding this comment.
Stale test expects removed description
Medium Severity
ReasonExpansion no longer renders a long description after reasonLongDescription was removed, but droppedDataOutcomeList.spec.tsx still expects that copy to appear when a reason row is expanded. The leftover assertion will fail.
Reviewed by Cursor Bugbot for commit 512acd1. Configure here.
There was a problem hiding this comment.
Adjust the test to make CI happy; deletion of the long description taken care of here #127713
This branch was successfully deployed
2 participants
Expands the dropped-data reason registry in
static/app/components/droppedData/outcomes.tsxfrom the initial ~34-reason subset (DAIN-1889) to the full set of ~130 outcome/reason codes from the "Dropped Events Descriptions for Humans and Agents" doc. Each reason now has a title (row heading), a short line (muted sub-line), and a long paragraph (drawer expansion) where the doc provides them.Refs DAIN-1937