Repository navigation
Conversation
Fixes the focus() slowdown from 30.1.2 that held up the last bump, plus a pile of getComputedStyle fixes. 30.1.3 is under pnpm's 12h minimumReleaseAge so it's excluded for now, can drop that once it ages out. https://github.com/jsdom/jsdom/releases/tag/v30.1.3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jsdom can't evaluate the breadcrumb's @container query, so the crumb's base display: none wins and 30.1.3 refuses to focus the search input inside it. Set the value with fireEvent.change instead of typing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jsdom can't evaluate the breadcrumb's container query, so tabbing past the field targets a crumb jsdom won't focus and the field never blurs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jsdom now resolves the computed overflow shorthand to visible instead of an empty string, so assert html overflow isn't hidden. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Removed jsdom version from minimumReleaseAgeExclude.
The padding test restored its scrollTo spy before afterEach flushed the release frame, so jsdom's unimplemented scrollTo logged errors. Lean on the beforeEach spy instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps jsdom 30.1.1 -> 30.1.3. Fixes the
focus()slowdown from 30.1.2 that held up #126489, plus a bunch ofgetComputedStylefixes.jsdom now checks the cascade before focusing and it can't evaluate container queries, so the settings breadcrumb search input is treated as hidden. Worked around that one spec with
fireEvent.change.https://github.com/jsdom/jsdom/releases/tag/v30.1.3