Repository navigation
Conversation
Add the service account management endpoints and the Seer-only viewer context endpoint behind organizations:service-accounts. They validate input and return canned data with the final response shape so Seer can integrate against the contract while the real implementation is built.
Split create and update request serializers so updates are optional in the schema, type the validated request data, and return real datetimes so the spec carries date-time formats.
Management endpoints live in the control silo with the service accounts. The Seer-only viewer context endpoint stays in the cell, since Seer only reaches its region's Sentry, and moves to its own module. Its response now mirrors agent token minting by including scopes, and OIDC scopes are no longer grantable.
gricha
marked this pull request as ready for review
October 15, 2026 21:13
trevor-e
approved these changes
Oct 15, 2026
Send the service account management routes to control in the API gateway and list them as control silo URLs. The Seer-only viewer context route stays on the cell.
Contributor
Backend Test FailuresFailures on
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mocked service account APIs behind
organizations:service-accounts. They return canned, fully typed responses and persist nothing, so Seer can build against the contract while the real implementation lands behind it.GET/POST /organizations/{org}/service-accounts/andGET/PUT/DELETE .../{id}/. Reads needorg:read, writes needorg:admin, and you can only grant scopes you hold.POST .../{id}/viewer-context/. This is the service account counterpart of agent token minting. Seer sends its org-only ViewerContext and gets back{viewerContext, expiresAt, scopes}. It lives in the cell because Seer only reaches its region's Sentry. Until the service account actor exists, it returns Seer's own ViewerContext.owneris a placeholder until the owning team has a tag.Design: Service accounts, build order.
Depends on #127716 (control silo URL patterns, frontend), which lands first.