Repository navigation
ref(scraps): Require explicit React imports - #127532
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
TkDodo
added this pull request to stack #127534
October 15, 2026 12:41
natemoo-re
approved these changes
Oct 15, 2026
Base automatically changed from
tkdodo/ref/move-isolated-core-to-scraps
to
master
October 15, 2026 18:16
TkDodo
force-pushed
the
tkdodo/ref/scraps-explicit-react-imports
branch
from
October 15, 2026 18:16
f765d56 to
54fdb52
Compare
TkDodo
marked this pull request as ready for review
October 16, 2026 07:37
priscilawebdev
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scraps now requires explicit React imports for type and runtime references. This prevents generated declarations such as
React.ReactNodefrom depending on a consumer's global React namespace.The rule is enabled for Scraps source and colocated tests. Existing uses get type-only imports. Regression tests cover global references, explicit imports, local bindings, and configured globals.
Targets the extraction branch in #127513.