Repository navigation
ref(issueDetails): Break circular dependency between sidebar and detectorSection - #127477
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
SidebarSection.Title was a styled h6, which the scraps prefer-primitives rule flags. It now renders Heading as an h6 at size md with the muted variant, keeping a styled layer only for the flex layout that centers trailing InfoTips and icons, and the top margin. The lint violation is gone, so the sidebarSection.tsx entry is removed from oxlint-suppressions.json.
This was referenced Oct 15, 2026
…variant SidebarSection.Title now accepts a Heading variant, so the primary color no longer needs a styled override. Merged and Similar Issues render SidebarSection.Title directly, and detectorSection keeps a local styled title that only adds the bottom margin.
Heading has no margin props, so the detector title's bottom spacing now comes from a Container marginBottom rather than a local styled wrapper.
ryan953
approved these changes
Oct 15, 2026
ryan953
added
the
Trigger: getsentry tests
ryan953
enabled auto-merge (squash)
October 15, 2026 03:46
3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sidebar.tsxexportedSidebarSectionTitle, anddetectorSection.tsx,mergedSidebarSection.tsx, andsimilarIssuesSidebarSection.tsximported it back whilesidebar.tsximported them, creating circular dependencies. The shared export is removed: all three sections render<SidebarSection.Title variant="primary">directly, with the detector section wrapping it in<Container marginBottom="md">for spacing.To support that,
SidebarSection.Titleis now built onHeading(as="h6",size="md",variant="muted"by default) instead of a styledh6, and callers can passvariantto change the color. This clears its@sentry/scraps/prefer-primitivessuppression. A small styled layer keepsdisplay: flexwith a gap, because release sidebar titles such as "Adoption Stage" and "Sessions Adopted" carry a trailingInfoTipor icon that must stay vertically centered.Review focus:
Headinguses medium font weight andtext-box-trim, so the titles in the release details sidebar and the issue details sidebar (Merged Issues, Similar Issues, detector section) may render slightly differently. No feature flags.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-8ZM
Fixes CODING-CONVENTIONS-8ZZ
Fixes CODING-CONVENTIONS-906
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run