Repository navigation
ref(detectors): Break circular dependency in metric detector search bar - #127467
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 75275eb. Configure here.
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
Drop the re-export from metricFormData so the moved form field types, names, and hook have a single import path. Also export PrioritizeLevelFormData, which metricFormData still uses after the move and was failing typecheck.
ryan953
approved these changes
Oct 15, 2026
ryan953
enabled auto-merge (squash)
October 15, 2026 15:59
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
A runtime circular dependency existed between detector dataset configuration and metric form data:
getDatasetConfig.tsx→metrics.tsx→metricsSearchBar.tsx→metricFormData.tsx→getDatasetConfig.tsx.metricsSearchBar.tsxonly needsMETRIC_DETECTOR_FORM_FIELDSanduseMetricDetectorFormField, but importing them frommetricFormData.tsxpulled ingetDatasetConfig, closing the loop.Solution
METRIC_DETECTOR_FORM_FIELDS,useMetricDetectorFormField, and metric detector form types into a standalonemetricFormFields.tsxthat does not importgetDatasetConfig.metricsSearchBar.tsx) to import the moved symbols frommetricFormFields.tsx.metricFormData.tsxdoes not re-export them, so each symbol has one import path.PrioritizeLevelFormDatafrommetricFormFields.tsx, becausemetricFormData.tsxstill uses it.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-92W
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run