ref(explore): Break data browsing dependency cycles

[TkDodo]

Break the circular imports reported by 22 no-circular-dependencies issues across Explore, Discover, trace details, and performance transaction summaries.

This touches more files and codeowners than I wanted to, but my agent tried to work around this with re-exports to keep the import paths the way they are, but that’s worse.

Sentry Issues

Fixes CODING-CONVENTIONS-8Z5
Fixes CODING-CONVENTIONS-8Z6
Fixes CODING-CONVENTIONS-905
Fixes CODING-CONVENTIONS-90Q
Fixes CODING-CONVENTIONS-90R
Fixes CODING-CONVENTIONS-91B
Fixes CODING-CONVENTIONS-91H
Fixes CODING-CONVENTIONS-91J
Fixes CODING-CONVENTIONS-922
Fixes CODING-CONVENTIONS-92G
Fixes CODING-CONVENTIONS-92Q
Fixes CODING-CONVENTIONS-97H
Fixes CODING-CONVENTIONS-9BT
Fixes CODING-CONVENTIONS-9G2
Fixes CODING-CONVENTIONS-9GH
Fixes CODING-CONVENTIONS-9GM
Fixes CODING-CONVENTIONS-9GS
Fixes CODING-CONVENTIONS-9GW
Fixes CODING-CONVENTIONS-9MD
Fixes CODING-CONVENTIONS-9ME
Fixes CODING-CONVENTIONS-9MG
Fixes CODING-CONVENTIONS-9MH

[github-actions]

📊 Type Coverage Diff

Metric	Before	After	Delta
Coverage	95.72%	95.72%	±0%
Typed	142,212	142,216	🟢 +4
Untyped	6,363	6,363	±0

🔍 7 new type safety issues introduced

any-typed symbols (1 new)

File	Line	Detail
static/app/components/searchQueryBuilder/tokens/filter/getOperatorInfo.tsx	87	opLabel (var)

Non-null assertions (!) (4 new)

File	Line	Detail
static/app/components/searchQueryBuilder/tokens/filter/filterValueText.tsx	216	items[0]!
static/app/components/searchQueryBuilder/tokens/filter/filterValueText.tsx	219	items[0]!
static/app/components/searchQueryBuilder/tokens/filter/filterValueText.tsx	232	item.value!
static/app/views/performance/traceDetails/traceModels/makeExampleTraceData.ts	23	root.children[root.children.length - 1]!

Type assertions (as) (2 new)

File	Line	Detail
static/app/views/discover/savedQuery/datasets.ts	12	as DiscoverDatasets — dataset as DiscoverDatasets
static/app/views/discover/savedQuery/datasets.ts	33	as SavedQueryDatasets — savedQueryDataset as SavedQueryDatasets

This is informational only and does not block the PR.

[JoshuaKGoldberg]

but my agent tried to work around this with re-exports

Mine did that too when I last did this kind of thing! So annoying!!

[TkDodo]

Mine did that too when I last did this kind of thing! So annoying!!

@JoshuaKGoldberg should we forbid re-exports with a lint rule and then maybe have exceptions for our barrels (until we get rid of barrels altogether), e.g. by disallowing re-exports in files that are not only re-exports ?

[JoshuaKGoldberg]

💯 yes!