Repository navigation
Conversation
Download version-1 flamegraph attachments and adapt their independent call trees to the existing count-based profiling visualization. Keep MetricKit rendering unchanged and gate the new viewer behind the flamegraph attachment feature flag.
github-actions
Bot
added
the
Scope: Frontend
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-h890k304j.sentry.dev |
Contributor
📊 Type Coverage Diff
🔍 4 new type safety issues introducedNon-null assertions (
Type assertions (
This is informational only and does not block the PR. |
philprime
marked this pull request as ready for review
October 15, 2026 13:38
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit abc84f3. Configure here.
scttcper
reviewed
Oct 15, 2026
scttcper
reviewed
Oct 15, 2026
scttcper
reviewed
Oct 15, 2026
scttcper
reviewed
Oct 15, 2026
1 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated Flamegraph section to issue details when an event has a version-1
event.flamegraphattachment. It uses the existing attachment listing and download endpoints, with loading, explicit retry, and unsupported-format handling. The section is gated byevent-attachmentsandflamegraph-attachments.The viewer reuses the profiling canvas, theme, hover tooltips, and scrolling used by MetricKit flamegraphs without changing the existing MetricKit implementation. A separate adapter converts attachment nodes into weighted paths, preserving inclusive counts, samples ending at intermediate nodes, repeated frames, and recursion. Multiple attachments and call trees can be selected independently. Unclassified frames use the system-frame color.
Backend prerequisite: #126459. Land the backend first so the feature flag is exposed to the UI.
The 33 focused tests include the existing MetricKit and view-hierarchy suites. Full frontend typechecking and lint passed. Playwright verification against a local event attachment confirmed a painted canvas, independent tree counts, hover tooltips, scrolling, and collapse persistence. Diagnostic payloads and browser artifacts are not included.