Repository navigation
Conversation
Author
|
could a collaborator add the Trigger: getsentry tests label after reviewing this and authorize the Vercel preview? those checks are waiting on approval |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #126295
Three recent non-semver releases can switch a project back to release-order comparison. An older semantic version created later can then reopen an issue that was already resolved
This adds an opt-in
semverfield to the project API, backed bysentry:semverand gated byorganizations:project-semver-ordering. When enabled, valid semantic releases keep semantic ordering regardless of recent release names. The preference is checked before the heuristic cache, so changing it takes effect immediatelyAutomatic detection remains the default. Non-semver release versions still use the existing release-order fallback. Projects can turn the setting off even after the feature flag is disabled
This PR contains the backend change only. A settings-page toggle should follow separately under the repository's backend/frontend deployment rules. Feature rollout is not included
Validation
The backend workflow passed on
c31afede, including all 22 backend test shards, API docs tests, migrations, and typing. GitHub pre-commit lint and both Sentry and Cursor reviews also passed on this revisionRuff lint and format checks passed locally for all ten PR files, and
git diff --checkpassed. The regression test was verified to fail before the original fixLocal pytest could not be rerun after the upstream merge because its container environment was unavailable. The local
prekattempt timed out; GitHub's pre-commit job completed successfullyThe optional OpenAPI comparison reports the expected
semveradditions against the production schema. Vercel requires Sentry team authorization. Downstreamgetsentrytests require a collaborator to add theTrigger: getsentry testslabel after reviewing the codeAI assistance was used for implementation, review, and running the checks listed above
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.