fix(issues): Prevent focus trap conflict in assignee selector ownership modal - #123109
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(issues): Prevent focus trap conflict in assignee selector ownership modal#123109sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a "RangeError: Maximum call stack size exceeded" that occurred when attempting to open the ownership rule modal from the assignee selector's footer on the issue details page.
The root cause was a conflict between two focus containment libraries:
react-aria(used by theCompactSelectoverlay in the assignee selector) andfocus-trap(used by the ownership rule modal). When the ownership modal was opened, theCompactSelectoverlay remained active, leading to both components attempting to control focus simultaneously, resulting in an infinite loop of focus events.The fix involves modifying the
additionalMenuFooterItemsprop inAssigneeSelectorDropdownto accept a render prop that provides acloseOverlayfunction. The "Ownership" button inviews/issueDetails/header/assigneeSelector.tsxnow utilizes thiscloseOverlayfunction to explicitly dismiss theCompactSelectoverlay before opening the ownership rule modal. This ensures only one focus trap is active at a time, preventing the conflict and the resulting stack overflow.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-391T
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.