Skip to content

[DRAFT] Remove query_builder from mypy module-ignore list - #123107

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-1bd8
Draft

[DRAFT] Remove query_builder from mypy module-ignore list#123107
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-1bd8

Conversation

@cursor

@cursor cursor Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove sentry.snuba.metrics.query_builder from the tool.mypy.overrides typing-issues (disable_error_code) list in pyproject.toml
  • fix the resulting typing issues in src/sentry/snuba/metrics/query_builder.py via explicit type narrowing, stricter aliases, and safe parameter coercion helpers
  • keep runtime behavior unchanged while making the module pass without the typing-issues override

Testing

  • PATH="/workspace/.venv/bin:$PATH" .venv/bin/python -m tools.mypy_helpers.mypy_without_ignores src/sentry/snuba/metrics/query_builder.py
  • .venv/bin/python -m tools.mypy_helpers.check_stronglist pyproject.toml
  • PATH="$HOME/.local/bin:$PATH" .venv/bin/prek run -q --files src/sentry/snuba/metrics/query_builder.py pyproject.toml
  • SENTRY_SKIP_SERVICE_VALIDATION=1 .venv/bin/pytest -n3 -svv --reuse-db tests/sentry/snuba/metrics/test_query_builder.py (fails in this VM: redis on localhost:6379 unavailable and Docker/devservices are not installed in the environment)

@armenzg could you please review this draft PR?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant