test(admin): Speed up customer details tests - #123102
Draft
scttcper wants to merge 2 commits into
Draft
Conversation
The suite repeatedly mounted the full customer details page to check the same menu and modal plumbing. Consolidate overlapping scenarios around the distinct actions they cover and reset ConfigStore per test so permissions no longer leak between cases. Cuts the focused suite from 63 tests to 39 and about a third off the runtime. Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
scttcper
changed the title
Put the router and organization setup back at each call site instead of hiding it behind a shared helper. Co-Authored-By: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suite was mounting the full customer details page over and over to check the same action menu and modal plumbing.
Consolidates overlapping cases around the distinct visibility and mutation behavior they cover, and resets ConfigStore per test so permissions do not leak between cases.
about a third faster and a thousand lines less test noise.