fix(auth): set sso flags on invite accept - #123088
Merged
Merged
Conversation
Invite acceptance only attached the user and left sso:linked unset, so the first post-login org hit failed sso_is_valid and bounced back through needs_sso for a second IdP round-trip. Co-Authored-By: Nora Shapiro <nora.shapiro@sentry.io>
github-actions
Bot
added
the
Scope: Backend
nora-shap
marked this pull request as ready for review
August 28, 2026 23:36
Lock the invite-accept path that must set sso:linked so post-login redirect reaches the org once instead of bouncing through needs_sso. Co-Authored-By: Nora Shapiro <nora.shapiro@sentry.io>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9fa2374. Configure here.
evanpurkhiser
approved these changes
Aug 31, 2026
Pre-commit injected this coverage onto the PR; the assertion is wrong for sentry-auth-organization on a customer domain, so remove it. Co-Authored-By: Nora Shapiro <nora.shapiro@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new user accepted an invite to an SSO Org, we take them through the initial login and confirmation screen where we create a new user. Instead of bringing them into the app, we brought them back to the
loginpage where they needed to clicklogin with SSOagain because we weren't settingsso__linked = Trueon invite acceptance.