feat(pr_metrics): Include group_ids in delegated agent attribution#119810
Open
giovanni-guidini wants to merge 1 commit into
Open
feat(pr_metrics): Include group_ids in delegated agent attribution#119810giovanni-guidini wants to merge 1 commit into
giovanni-guidini wants to merge 1 commit into
Conversation
DelegatedAgentSignalDetails previously only carried agent_id/pr_url/run_id, even though the resolved group ids were already available at write time in two of its three call sites: the synchronous Seer match response already had them on the outbound MatchDelegatedAgentPrRequest, and the Copilot/Claude Code autofix pollers had them via the originating Group. Add a group_ids field to the schema and thread the existing values through both paths instead of dropping them. The Cursor webhook path and the async record_pr_attribution RPC callback are left as-is for now; group context isn't available there without new plumbing on the Seer side.
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want this because I recently moved the HEX dashboard to look for missing matches based on group_id match. It's harder for delegated agents cause we don't include those in the attribution.
Adds a
group_idsfield toDelegatedAgentSignalDetailsand populates it on the two write paths where the resolved group ids were already available but previously discarded:_send_seer_delegated_agent_match) already sendsgroup_idsto Seer on the outboundMatchDelegatedAgentPrRequest; those same ids are now carried into the storedsignal_details.group_idfrom the originatingGroup(viaGroupAutofixEndpoint.get) down throughpoll_github_copilot_agents/poll_claude_code_agentsinto the attribution write.The Cursor webhook path and the async
record_pr_attributionRPC callback are left unchanged — neither has group context readily available without new plumbing on the Seer side, and can be addressed separately.